fix bugs around property loading, naming, and temp graph replacement #821
Conversation
| switch { | ||
| case errors.Is(err, graph.ErrVertexNotFound): | ||
| // do nothing | ||
| break |
There was a problem hiding this comment.
break? that'd break out of the for _, key := range topo loop, is that what you intended?
There was a problem hiding this comment.
nope definitely didnt mean for that to be there, removing
| @@ -4,11 +4,11 @@ resources: | |||
| parent: eks_cluster/eks_cluster-0 | |||
|
|
|||
|
|
|||
| load_balancer/rest-api-4-integ6897f0b9: | |||
| load_balancer/rest-api-4-integbcc77100: | |||
There was a problem hiding this comment.
Is this non-deterministic?
There was a problem hiding this comment.
i dont think so, the ordering did change, which i assumed was from the way we load the graph, but i ran the same architecture 10 times and always saw the same result
There was a problem hiding this comment.
Just wondering if the UUIDs weren't deterministic, do we set the seed somewhere?
There was a problem hiding this comment.
dont think we do, we could probably look into that
| @@ -4,11 +4,11 @@ resources: | |||
| parent: eks_cluster/eks_cluster-0 | |||
|
|
|||
|
|
|||
| load_balancer/rest-api-4-integ6897f0b9: | |||
| load_balancer/rest-api-4-integbcc77100: | |||
There was a problem hiding this comment.
Just wondering if the UUIDs weren't deterministic, do we set the seed somewhere?
fix bugs around property loading, naming, and temp graph replacement
Standard checks