Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase path_selection coverage to > 10% #904

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

gordon-klotho
Copy link
Contributor

@gordon-klotho gordon-klotho commented Jan 29, 2024

❯ go test -cover ./pkg/engine2/path_selection
ok      github.com/klothoplatform/klotho/pkg/engine2/path_selection     0.009s  coverage: 13.9% of statements

Standard checks

  • Unit tests: ✅
  • Docs: n/a
  • Backwards compatibility: ✅

target: "p:compute:e",
id: "p:glue:c",
wantWeight: 15,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add cases for in graph, but unrelated to downstream/upstream (checking that it uses the undirected graph to determine weight)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 was planning on doing that (among other changes) for the +7% this week

Copy link
Contributor

@jhsinger-klotho jhsinger-klotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking, but i dont think the unit tests really cover that much of the functionality of those methods because they only have 2 simple cases, so we should add more to those. the 13% seems like it might be because a lot of the code path is touched although we need to add in tests for more variation of how we would expect it to behave given certain inputs

@gordon-klotho gordon-klotho merged commit 6e8aafe into main Jan 30, 2024
6 checks passed
@gordon-klotho gordon-klotho deleted the testing/path_selection branch January 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants