-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print errors to stdout #920
Conversation
{ | ||
"error": { | ||
"chain": [ | ||
"required property Id is not set on resource aws:subnet:vpc-0:subnet-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id
is one of the "required + deploy time" variables. Those should probably not cause validation errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we have a card for this, so we might want to pick it up as a part of this workstream
"children": [ | ||
{ | ||
"chain": [ | ||
"invalid int value 80" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because they're "80" (string)
and not being converted to an int
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be able to be converted but if not we need to either cut a card or update the code
Don't know why the unit tests fail, they've been consistently successful for me. Looks like maybe some non-determinism on op eval? |
"showing the validation errors are demonstrating some gaps in the validation logic, but were unchanged by this PR." are the gaps just the 2 things you commented or are there more? |
89a6187
to
07b9c19
Compare
d258674
to
15af974
Compare
Note: the added testdata cases showing the validation errors are demonstrating some gaps in the validation logic, but were unchanged by this PR.
Standard checks