Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/un 2ify #930

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Task/un 2ify #930

merged 6 commits into from
Feb 8, 2024

Conversation

gordon-klotho
Copy link
Contributor

Remove the numeric suffix on:

  • engine2
  • knowledge_base2
  • construct2
  • visualizer2
  • infra/iac3

I used VS Code rename to rename the packages. The only manual change I made was da9cf1e because the visualizer2 folder didn't have the suffix in the package name, and the import is based on the folder name, not the package.

Standard checks

  • Unit tests: ✅
  • Docs: n/a
  • Backwards compatibility: no externally facing changes

@gordon-klotho gordon-klotho merged commit c296a78 into main Feb 8, 2024
6 checks passed
@gordon-klotho gordon-klotho deleted the task/un_2ify branch February 8, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants