auto generate deployment policy #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordon-klotho
approved these changes
Feb 27, 2024
| @@ -439,6 +440,20 @@ func (em *EngineMain) RunEngine(cmd *cobra.Command, args []string) (exitCode int | |||
| }, | |||
| ) | |||
|
|
|||
| if architectureEngineCfg.provider == "aws" { | |||
| polictBytes, err := aws.DeploymentPermissionsPolicy(context.Solutions[0]) | |||
There was a problem hiding this comment.
Since this is based on provider-agnostic fields on the templates, can this be run for everything?
Edit: I guess it needs the aws:iam_policy which is provider specific. Hm... I guess this is alright, I can't think of anything better but still feels "icky" 😄
There was a problem hiding this comment.
its run on the entire architecture but the function only considers permissions. i think its fair to have some provider specific post processing
| @@ -0,0 +1,118 @@ | |||
| { | |||
| "Statement": [ | |||
There was a problem hiding this comment.
Will we run into any size limits with these?
There was a problem hiding this comment.
yeah im sure we will at some point, but i figure we will have to try to solve that if it comes up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to produce a basic deployment policy for the architecture
added test cases to the functional tests
Standard checks