Lenient string prop

pkg/engine/operational_eval/vertex_path_expand.go

@@ -135,6 +135,10 @@ func (v *pathExpandVertex) addDepsFromProps(
 	}
 	var errs error
 	for k, prop := range tmpl.Properties {
+		// Only consider properties whose type can even accommodate a resource
+		if !strings.HasPrefix(prop.Type(), "resource") {
+			continue
+		}
 		details := prop.Details()
 		if details.OperationalRule == nil {
 			// If the property can't create resources, skip it.

pkg/engine/operational_eval/vertex_path_expand_test.go

@@ -154,6 +154,7 @@ func Test_pathExpandVertex_addDepsFromProps(t *testing.T) {
 
 				mockSol.On("RawView").Return(resultGraph).Once()
 				mockProperty.EXPECT().Validate(resource, construct.ResourceId{Name: "u"}, gomock.Any()).Return(nil).Times(1)
+				mockProperty.EXPECT().Type().Return("resource").Times(1)
 				return nil
 			},
 			want: graphChanges{

pkg/knowledgebase/properties/string_property.go

@@ -64,12 +64,15 @@ func (str *StringProperty) Parse(value any, ctx knowledgebase.DynamicContext, da
 	if err == nil {
 		return val, nil
 	}
-	if val, ok := value.(string); ok {
-		var result string
-		err := ctx.ExecuteDecode(val, data, &result)
-		return result, err
+	switch val := value.(type) {
+	case string:
+		err := ctx.ExecuteDecode(val, data, &val)
+		return val, err
+
+	case int, int32, int64, float32, float64, bool:
+		return fmt.Sprintf("%v", val), nil
 	}
-	return nil, fmt.Errorf("could not parse string property: invalid string value %v", value)
+	return nil, fmt.Errorf("could not parse string property: invalid string value %v (%[1]T)", value)
 }
 
 func (s *StringProperty) ZeroValue() any {

pkg/knowledgebase/properties/string_property_test.go

@@ -235,13 +235,23 @@ func Test_StringParse(t *testing.T) {
 			expected: "test",
 		},
 		{
-			name: "non string throws error",
+			name: "non string converts int",
+			property: &StringProperty{
+				PropertyDetails: knowledgebase.PropertyDetails{
+					Path: "test",
+				},
+			},
+			value:    1,
+			expected: "1",
+		},
+		{
+			name: "non string fails non-primitive",
 			property: &StringProperty{
 				PropertyDetails: knowledgebase.PropertyDetails{
 					Path: "test",
 				},
 			},
-			value:   1,
+			value:   []string{"hi"},
 			wantErr: true,
 		},
 	}