support imported edges #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2024 08:30
jhsinger-klotho
force-pushed
the
imported_edges
branch
from
47600c5 to
2c1ff5c
Compare
gordon-klotho
approved these changes
Mar 8, 2024
| @@ -47,6 +47,20 @@ func (v *pathExpandVertex) Key() Key { | |||
| } | |||
|
|
|||
| func (v *pathExpandVertex) Evaluate(eval *Evaluator) error { | |||
| // if both the source and target are imported resources we can skip the evaluation since its just for context | |||
| // we will ensure the edge remains | |||
| sourceRes, err := eval.Solution.RawView().Vertex(v.SatisfactionEdge.Source) | |||
There was a problem hiding this comment.
IMO these shouldn't even result in a pathExpandVertex because it gives the wrong impression looking at the eval graph. Not a blocker though since it doesn't change behaviour.
| function properties(object: ReturnType<typeof create>, args: Args) {} | ||
| function properties(object: ReturnType<typeof create>, args: Args) { | ||
| return { | ||
| DomainName: pulumi.interpolate`https://${object.domainName}`, |
There was a problem hiding this comment.
This isn't the domain name, but a URL base.
Co-authored-by: Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard checks