Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use imports in path selection and more state conversion #978

Closed
wants to merge 2 commits into from

Conversation

jhsinger-klotho
Copy link
Contributor

@jhsinger-klotho jhsinger-klotho commented Apr 4, 2024

gives the ability to script path satisfaction (this allows us to conditionally choose what resources the paths are going to/coming from)

removes speculative dependencies of path selection and just relies on the dependencies of the scripts/property references (this is responsible for some naming changes around the test data)

  • adds checks to ensure we are choosing paths which dont change properties of imported resources
  • ensures that we dont only consider direct edges for imported resource path expansion
  • allows resources to deny themselves from being used in specific path selection classifications

adds the ability to read state for fields that need to be translated to field Refs or resource ids

making sure imports work with more resources

Gets ECS Dynamic port mappings to work as well

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@gordon-klotho gordon-klotho self-requested a review April 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant