Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ecs images be able to be strings #980

Merged
merged 2 commits into from
Apr 19, 2024
Merged

make ecs images be able to be strings #980

merged 2 commits into from
Apr 19, 2024

Conversation

jhsinger-klotho
Copy link
Contributor

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

gordon-klotho
gordon-klotho approved these changes Apr 17, 2024
View reviewed changes
pkg/templates/aws/resources/ecs_task_definition.yaml Outdated
Comment on lines 107 to 108
description: Reference to an Amazon Elastic Container Registry (ECR) image that
will be used for the container within the task
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably update this to reflect the type change (and probably hint at being a property ref).

gordon-klotho
gordon-klotho approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@gordon-klotho gordon-klotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests 💯

@jhsinger-klotho jhsinger-klotho merged commit cd8706f into main Apr 19, 2024
6 checks passed
@jhsinger-klotho jhsinger-klotho deleted the string_image branch April 19, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordon-klotho gordon-klotho gordon-klotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhsinger-klotho @gordon-klotho