Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More conky updates #208

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

More conky updates #208

wants to merge 1 commit into from

Conversation

nandub
Copy link

@nandub nandub commented Feb 2, 2021

I added the changes on top of pull #185, you can merge this one instead of the other one.

  • it has pull Conky improvements #185 changes
  • other improvements and
  • implemented maidenhead grid locator on the C (conky/maidenhead.c) language:
    • get maidenhead (c implementation) with gpspipe (to get latitude and longitude) gcc is required. see conky/get-grid file.
    • get maidenhead (c implementation) with passing arguments (passing latitude and longitude as arguments) gcc is required. see conky/get-grid file.
    • get maidenhead (ruby implementation) fallback to this one if gcc is not installed (different OS maybe). see conky/get-grid.rb file.

@km4ack
Copy link
Owner

km4ack commented Feb 2, 2021

I am going to hold off on this pull for the time being. Some users are having issues around Conky and the GPS with the way it currently is implemented. This is causing Conky to either crash or fail to start. I will be making changes soon (hopefully this week) to try and eliminate the Conky issues.

@nandub
Copy link
Author

nandub commented Feb 2, 2021

@km4ack let me know if you need help with testing. I have a GPS dongle attached to an rpi2.

@nandub nandub force-pushed the more-conky-updates branch from 5a0988a to 5ed4be6 Compare February 2, 2021 18:22
@nandub nandub mentioned this pull request Feb 2, 2021
Closed
@nandub nandub force-pushed the more-conky-updates branch 2 times, most recently from 50233c2 to 7122406 Compare February 12, 2021 00:00
@nandub nandub force-pushed the more-conky-updates branch from 7122406 to 1db9060 Compare February 24, 2021 23:09
@km4ack
Copy link
Owner

km4ack commented Mar 17, 2021

Have you tried the latest BAP 3.0.7 to see if you are still having issues with the GPS and conky?

@darigovresearch
Copy link

@nandub are you still having issues with the latest BAP 3.0.7?

@nandub nandub force-pushed the more-conky-updates branch 2 times, most recently from d3f4a56 to e340059 Compare August 20, 2021 17:55
@nandub
Copy link
Author

nandub commented Aug 20, 2021

@km4ack sorry I didn't get back to you sooner to answer. I was not having issues with conky and GPS but rather I was improving the code. This pull request is adding another way to get grid/maidenhead without using ruby. I added a function to retrieve with gpspipe or using C code to calculate the grid.

I re-based the branch against current dev to remove the current conflicts so it should merge cleanly. Let me know what you think.

@nandub
add more options to get maidenhead
fcd20dd 
- it has pull km4ack#185 changes
- other improvements and
- implemented maidenhead grid locator on the C (conky/maidenhead.c) language:
      - get maidenhead (c implementation) with gpspipe (to get latitude and longitude) gcc is required. see conky/get-grid file.
      - get maidenhead (c implementation) with passing arguments (passing latitude and longitude as arguments) gcc is required. see conky/get-grid file.
      - get maidenhead (ruby implementation) fallback to this one if gcc is not installed (different OS maybe). see conky/get-grid.rb file.
@nandub nandub force-pushed the more-conky-updates branch from e340059 to fcd20dd Compare October 6, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandub @km4ack @darigovresearch