forked from mastodon/mastodon
-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: #8 サークル投稿の転送 #294
Merged
Merged
Add: #8 サークル投稿の転送 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmycode
force-pushed
the
kbtopic-8-circle-reply
branch
2 times, most recently
from
November 20, 2023 04:15
d152676
to
d3182a7
Compare
kmycode
force-pushed
the
kbtopic-8-circle-reply
branch
from
November 20, 2023 04:37
a058b4a
to
1d9ff2a
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has resolved merge conflicts and is ready for review. |
…astodon into kbtopic-8-circle-reply
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has resolved merge conflicts and is ready for review. |
…astodon into kbtopic-8-circle-reply
kmycode
commented
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
自分のサーバーで
limited_scope = 'Reply'
の追加context
を追加他サーバーから
limited_scope = 'Reply'
の受け入れcontext
をダウンロード・取得する処理Web UI
visibility = limited
の場合にサークルIDの指定がこれまで必須だったが、なくても返信であれば返信として扱うようにするテスト
kmyblueの投稿にFedibirdから返信したものを第三者がkmyblueから観測複雑なケース
Conversation
のparent_status
についてFedibirdの
Conversation
にあるparent_status
プロパティについて、以下の理由からローカルサーバーの投稿のみ必要、リモートに関しては不要と判断するconversation
のinbox_url
に送信すればいいのでparent_status
は必要がないreply
より明らかなのでparent_status
は必要がないreply
より明らかなのでparent_status
は必要がないcontext
だけを指定してきた通常投稿の場合、parent_status
から元になる投稿を特定する必要があるので必要statuses
テーブルをconversation_id
で検索する方法が考えられるが、そもそも1つのconversation
は複数のstatus
を持ちうるのでどれなのか判別がつかないstatus
のid
やlimited_scope
で判定するのは、今後の仕様追加や別の仕様変更との競合を考えると危ないparent_status
は必要がないなおFedibirdのプロパティ名
parent_status
は親の親がいることが分かりづらいので、kmyblueではancestor_status
に置き換えるところでFedibirdにある
parent_account
ってどんな時に必要なんでしょう‥‥?転送処理と
ancestor_status
の使用to
にcontext
のuriが入っており、かつ限定投稿である場合に転送するancestor_status
はあくまで投稿を特定する場合のみに使うancestor_status
のメンション先+新しい投稿で新たに追加されたメンション先inbox_url
のないconversation
には転送しない(バージョン9以前のkmyblueでは入ってない)【参考】現在のActivityの差分
kmyblue
※ #283 適用後
Fedibird
searchableBy
は #88 で対応するため、今回は対応不要。to
とcontext
だけやる