Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code formatting check post Pull-Request (#3349) #4028

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Code formatting check post Pull-Request (#3349) #4028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4909b5d
Add Code formatting check post Pull-Request (#3349)
prakhar479 Aug 5, 2024
32929c7
added formatting test for Control plane build tests
prakhar479 Aug 24, 2024
46fdb5a
provided excutable perms to presubmit-test.sh
prakhar479 Aug 24, 2024
b39eebd
changed formatting tests from control plane to data plane
prakhar479 Aug 24, 2024
62ba7b2
add return to original working directory after build_tests
prakhar479 Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/knative-java-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ jobs:
- name: Java Test
run: ./hack/run.sh unit-tests-data-plane

- name: Code Formatting Check
run: ./hack/run.sh format-check

- if: steps.codecov-enabled.outputs.files_exists == 'true'
name: Codecov
uses: codecov/codecov-action@v1
Expand Down
3 changes: 3 additions & 0 deletions hack/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ elif [[ "${action}" == "integration-test" ]]; then
elif [[ "${action}" == "format-java" ]]; then
cd "${ROOT_DIR}/data-plane"
./mvnw spotless:apply
elif [[ "${action}" == "format-check" ]]; then
cd "${ROOT_DIR}/data-plane"
./mvnw spotless:check
else
echo "Unrecognized action ${action}"
usage "$0"
Expand Down
6 changes: 6 additions & 0 deletions test/presubmit-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ function fail_test() {
function build_tests() {
header "Running control plane build tests"
default_build_test_runner || fail_test "Control plane build tests failed"

header "Running data plane formatting tests"

cd $(dirname "$0")/../data-plane || fail_test "Failed to change to the data plane directory"
./mvnw spotless:check || fail_test "data plane formatting check failed"
cd - || fail_test "Failed to return to the original directory"
}

function unit_tests() {
Expand Down