Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: feat: triggerv2 supports cross namespace references #4060
base: main
Are you sure you want to change the base?
[WIP]: feat: triggerv2 supports cross namespace references #4060
Changes from all commits
a1bb7a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 207 in control-plane/pkg/reconciler/trigger/v2/controllerv2.go
Codecov / codecov/patch
control-plane/pkg/reconciler/trigger/v2/controllerv2.go#L207
Check warning on line 210 in control-plane/pkg/reconciler/trigger/v2/controllerv2.go
Codecov / codecov/patch
control-plane/pkg/reconciler/trigger/v2/controllerv2.go#L210
Check warning on line 219 in control-plane/pkg/reconciler/trigger/v2/controllerv2.go
Codecov / codecov/patch
control-plane/pkg/reconciler/trigger/v2/controllerv2.go#L217-L219
Check warning on line 222 in control-plane/pkg/reconciler/trigger/v2/controllerv2.go
Codecov / codecov/patch
control-plane/pkg/reconciler/trigger/v2/controllerv2.go#L221-L222
Check warning on line 100 in control-plane/pkg/reconciler/trigger/v2/triggerv2.go
Codecov / codecov/patch
control-plane/pkg/reconciler/trigger/v2/triggerv2.go#L99-L100