Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test EventType auto-create for KafkaChannel #4074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test EventType auto-create for KafkaChannel #4074

wants to merge 1 commit into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 20, 2024 •
edited
Loading

Proposed Changes

Add tests for the following:

  • EventType auto-create for KafkaChannel on replies to subscriptions

Release Note

Docs

@knative-prow knative-prow bot requested review from Leo6Leo and matzew August 20, 2024 08:34
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test labels Aug 20, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (21f8e98) to head (09015d4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4074   +/-   ##
=======================================
  Coverage   45.51%   45.51%           
=======================================
  Files         270      270           
  Lines       19925    19925           
=======================================
  Hits         9069     9069           
  Misses      10129    10129           
  Partials      727      727

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur mgencur mentioned this pull request Aug 20, 2024
Closed
matzew
matzew reviewed Aug 20, 2024
View reviewed changes
test/e2e_new/broker_test.go Outdated
@@ -255,6 +255,26 @@ func TestBrokerEventTypeAutoCreate(t *testing.T) {
env.Test(ctx, t, eventtype_autocreate.AutoCreateEventTypesOnBroker(brokerName))
}

func TestMTChannelBasedBrokerEventTypeAutoCreate(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for creating a test here, @mgencur

@mgencur mgencur mentioned this pull request Aug 20, 2024
Open
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2024
@mgencur mgencur force-pushed the eventtype_autocreate_main branch from 24e523c to c82d119 Compare September 10, 2024 09:37
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Sep 10, 2024

Testing again. The tests should pass after merging #4077

@mgencur mgencur changed the title [TEST ONLY] Test EventType auto-create for MTChannelBasedBroker with KafkaChannel [TEST ONLY] Test EventType auto-create for MTChannelBasedBroker and KafkaChannel Sep 10, 2024
@mgencur mgencur changed the title [TEST ONLY] Test EventType auto-create for MTChannelBasedBroker and KafkaChannel [TEST ONLY] Test EventType auto-create for KafkaChannel Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2024
@mgencur
Add TestChannelSubscriptionEventTypeAutoCreate
09015d4 
This tests eventype reference for KafkaChannel when the receiver replies
back
@mgencur mgencur force-pushed the eventtype_autocreate_main branch from 0144375 to 09015d4 Compare December 10, 2024 07:27
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
@mgencur mgencur changed the title [TEST ONLY] Test EventType auto-create for KafkaChannel Test EventType auto-create for KafkaChannel Dec 10, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 10, 2024

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main 09015d4 link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-ssl_eventing-kafka-broker_main 09015d4 link true /test channel-reconciler-tests-ssl
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main 09015d4 link true /test channel-reconciler-tests-sasl-ssl
reconciler-tests_eventing-kafka-broker_main 09015d4 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented Dec 10, 2024

The test still fail due to #4076

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees
No one assigned
Labels
area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @matzew @knative-prow-robot