Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE-1.10] Fix missing change in back-port #565 #569

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[RELEASE-1.10] Fix missing change in back-port #565 #569

merged 1 commit into from
Aug 7, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Aug 7, 2023

@knative-prow knative-prow bot requested review from cardil and krsna-m August 7, 2023 12:54
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023
@ReToCode ReToCode changed the title Fix missing change in back-port https://github.com/knative-extensions… [RELEASE-1.10] Fix missing change in back-port #565 Aug 7, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Aug 7, 2023

/assign @mgencur

@mgencur
Copy link
Contributor

mgencur commented Aug 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@mgencur
Copy link
Contributor

mgencur commented Aug 7, 2023

/approve

matzew
matzew approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@knative-prow knative-prow bot merged commit 5ed6957 into knative-extensions:release-1.10 Aug 7, 2023
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@cardil cardil Awaiting requested review from cardil

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@matzew matzew

@mgencur mgencur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReToCode @mgencur @matzew