Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Improve domain subcommands and some wording suggestions #62

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Improve domain subcommands and some wording suggestions #62

merged 4 commits into from
Jul 6, 2020

Conversation

chaozbj
Copy link
Contributor

@chaozbj chaozbj commented Jun 29, 2020

This PR is mainly used to address the issue: #41 and some wording suggestions from PR: #40:

  1. Return error for invalid --selector value when using domain set subcommand
  2. Add UT for adding domain with invalid selector
  3. Improve help and error message for domain set subcommand
  4. Remove For example: xxx from admin root command
  5. Set SilenceUsage: true for admin root command to keep the same behaivour as kn client
  6. Improve wording according to suggestions from: #40 (comment)

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 29, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2020
@knative-prow-robot
Copy link

Hi @chaozbj. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2020
@chaozbj chaozbj changed the title Improve domain subcommands and other wording suggestions Improve domain subcommands and some wording suggestions Jun 29, 2020
@zhanggbj
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2020
@chaozbj
Copy link
Contributor Author

chaozbj commented Jun 29, 2020

@navidshaikh: could you please help me review this RP since it addressed some wording improvements according to your suggestions in RP: #40? Thanks!

navidshaikh
navidshaikh suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits/typos but lgtm otherwise

plugins/admin/core/root.go Show resolved Hide resolved
plugins/admin/pkg/command/domain/set.go Outdated Show resolved Hide resolved
plugins/admin/pkg/command/domain/set_test.go Outdated Show resolved Hide resolved
maximilien
maximilien suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments

/ok-to-test

plugins/admin/core/root.go Show resolved Hide resolved
plugins/admin/core/root.go Show resolved Hide resolved
plugins/admin/pkg/command/registry/add.go Outdated Show resolved Hide resolved
plugins/admin/pkg/command/registry/registry.go Outdated Show resolved Hide resolved
@chaozbj
fixed review comments
fa8de61 
Signed-off-by: chaozbj <[email protected]>
@chaozbj
Copy link
Contributor Author

chaozbj commented Jul 2, 2020

@maximilien @zhanggbj @navidshaikh @12345lcr I addressed your comments, please help to review again. Thanks!

@chaozbj
Copy link
Contributor Author

chaozbj commented Jul 3, 2020

@maximilien I added a UT case for checking if the usage of root command has kn admin, please help to review again, thanks!

@chaozbj
Copy link
Contributor Author

chaozbj commented Jul 3, 2020

@navidshaikh @zhanggbj @12345lcr Following the comments #47 (comment), I changed the flag from --secret-name to --secret for registry add, please help to review, thanks!

navidshaikh
navidshaikh approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@navidshaikh navidshaikh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@zhanggbj unhold if you approve.

Besides, noticed the cobra is pinned at v0.0.5 in go.mod, we can also consider bumping that (in a separate PR) ?

plugins/admin/core/root.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaozbj, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@navidshaikh
Copy link
Contributor

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2020
@knative-prow-robot knative-prow-robot merged commit 59a725a into knative:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maximilien maximilien maximilien requested changes

@12345lcr 12345lcr 12345lcr left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chaozbj @knative-prow-robot @zhanggbj @navidshaikh @maximilien @12345lcr @googlebot