-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update brew command for kn #4176
Conversation
a formulae was merged in homebrew core to install kn without a specific tap
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: a844d25 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6138a33000fa5f00079ab607 😎 Browse the preview: https://deploy-preview-4176--knative.netlify.app |
docs/snippets/install-kn.md
Outdated
@@ -4,7 +4,7 @@ | |||
For macOS, you can install `kn` by using [Homebrew](https://github.com/knative/homebrew-client){target=_blank}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant, now that kn
can be installed from the main Homebrew tap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue in the homebrew-client repo knative/homebrew-client#32 and I will updated this PR.
you are correct we don't need this homebrew client repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced the URL with the one of brew main page.
/assign @omerbensaadon |
I solved the conflict |
/approve |
@omerbensaadon: once the present PR merges, I will cherry-pick it on top of release-0.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks @sebgoa!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, omerbensaadon, sebgoa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@omerbensaadon: #4176 failed to apply on top of branch "release-0.25":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a formulae was merged in homebrew core to install kn without a specific tap