-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker/Trigger Conformance Tests, invalid trigger.spec.filters #5089
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #5089 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 283 283
Lines 7947 7947
=======================================
Hits 6619 6619
Misses 956 956
Partials 372 372 Continue to review full report at Codecov.
|
/assign @vaikas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -309,6 +372,9 @@ func readyBrokerIsAddressable(ctx context.Context, t feature.T) { | |||
func brokerClassIsImmutable(ctx context.Context, t feature.T) { | |||
broker := getBroker(ctx, t) | |||
|
|||
if broker.Annotations == nil { | |||
broker.Annotations = map[string]string{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, since we use it right below.
broker.Annotations = map[string]string{} | |
broker.Annotations = make(map[string]string, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh, for a test, it does not matter much
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #4944
Testing that filters can not be make with invalid filters.