Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker/Trigger Conformance Tests, invalid trigger.spec.filters #5089

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Broker/Trigger Conformance Tests, invalid trigger.spec.filters #5089

merged 4 commits into from
Mar 18, 2021

Conversation

n3wscott
Copy link
Contributor

Related to #4944

Testing that filters can not be make with invalid filters.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 18, 2021
@knative-prow-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #5089 (02c5fb7) into main (48fb081) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5089   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         283      283           
  Lines        7947     7947           
=======================================
  Hits         6619     6619           
  Misses        956      956           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fb081...02c5fb7. Read the comment docs.

@n3wscott n3wscott marked this pull request as ready for review March 18, 2021 21:09
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2021
@n3wscott
Copy link
Contributor Author

/assign @vaikas

pierDipi
pierDipi reviewed Mar 18, 2021
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/rekt/features/broker/control_plane.go
@@ -309,6 +372,9 @@ func readyBrokerIsAddressable(ctx context.Context, t feature.T) {
func brokerClassIsImmutable(ctx context.Context, t feature.T) {
broker := getBroker(ctx, t)

if broker.Annotations == nil {
broker.Annotations = map[string]string{}
Copy link
Member

@pierDipi pierDipi Mar 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, since we use it right below.

Suggested change
broker.Annotations = map[string]string{}
broker.Annotations = make(map[string]string, 1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh, for a test, it does not matter much

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@pierDipi
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@knative-prow-robot knative-prow-robot merged commit 025f1c1 into knative:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

Assignees

@vaikas vaikas

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n3wscott @knative-prow-robot @pierDipi @vaikas