-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: update func go runtime dep #1879
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
==========================================
+ Coverage 61.80% 62.56% +0.76%
==========================================
Files 106 106
Lines 13777 13777
==========================================
+ Hits 8515 8620 +105
+ Misses 4410 4274 -136
- Partials 852 883 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
@lkingland it looks like newer version of runtime is not Windows compatible. |
Thanks! I updated the filter to only apply for linux, and to compare by hex |
@lkingland The |
35a319c
to
ab481cd
Compare
@lkingland I believe there is really a bug on Windows. I can reproduce it. |
a) It looks like "normal" user cannot create symlink:
b) even when running as an admin there is another issue:
|
It's probably not introduced by this PR but still needs fixing. |
That's great news you can reproduce! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "Unit Test (1.20.2, 17, windows-latest)" |
@lance: Overrode contexts on behalf of lance: Unit Test (1.20.2, 17, windows-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🧹 updates func runtime dependency
/kind cleanup