Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verbose default not applied #1884

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

lkingland
Copy link
Member

🐛 fixes a missing apply of the verbosity default

/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 24, 2023
@knative-prow knative-prow bot requested review from dsimansk and rhuss July 24, 2023 05:13
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21 🎉

Comparison is base (60aafba) 59.59% compared to head (26381d8) 59.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
+ Coverage   59.59%   59.80%   +0.21%     
==========================================
  Files         107      107              
  Lines       13739    13739              
==========================================
+ Hits         8188     8217      +29     
+ Misses       4726     4701      -25     
+ Partials      825      821       -4     
Flag Coverage Δ
e2e-test 35.58% <100.00%> (-0.03%) ⬇️
e2e-test-oncluster 30.60% <100.00%> (-0.03%) ⬇️
e2e-test-oncluster-runtime 25.61% <100.00%> (?)
e2e-test-runtime-go 25.96% <100.00%> (?)
e2e-test-runtime-node 26.97% <100.00%> (?)
e2e-test-runtime-python 26.97% <100.00%> (?)
e2e-test-runtime-quarkus 27.08% <100.00%> (?)
e2e-test-runtime-springboot 26.10% <100.00%> (?)
e2e-test-runtime-typescript 27.08% <100.00%> (?)
unit-tests-macos-latest 49.24% <100.00%> (+0.03%) ⬆️
unit-tests-ubuntu-latest 49.99% <100.00%> (-0.07%) ⬇️
unit-tests-windows-latest 49.26% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 82.22% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8703d9c into knative:main Jul 24, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants