-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pod security context #1889
Fix pod security context #1889
Conversation
This reverts commit cb6f33d.
This is needed to avoid circular package dependencies. Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PTAL @grafvonb |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
- Coverage 61.95% 59.90% -2.06%
==========================================
Files 106 106
Lines 13801 13802 +1
==========================================
- Hits 8551 8268 -283
- Misses 4397 4686 +289
+ Partials 853 848 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
β View full report in Codecov by Sentry. |
@matejvasek lgtm, it works as expected. The current version from
|
PTAL @jrangelramos @lance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lance this requires test override. |
/override "Unit Test (1.20.2, 17, windows-latest)" |
@lance: Overrode contexts on behalf of lance: Unit Test (1.20.2, 17, windows-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes