Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added standard labels for our builders #1934

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🧹 Added some standard org.opencontainers.image.* labels on our paketo jammy builders.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2023
@matejvasek matejvasek requested review from Shashankft9, gauron99, lkingland, salaboy and aslom and removed request for navidshaikh August 15, 2023 20:51
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.00% 🎉

Comparison is base (c8abe3e) 61.76% compared to head (515dd56) 62.76%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
+ Coverage   61.76%   62.76%   +1.00%     
==========================================
  Files         107      107              
  Lines       13818    13819       +1     
==========================================
+ Hits         8534     8673     +139     
+ Misses       4429     4267     -162     
- Partials      855      879      +24     
Flag Coverage Δ
e2e-test 35.51% <ø> (+0.02%) ⬆️
e2e-test-oncluster 30.80% <ø> (-0.01%) ⬇️
e2e-test-oncluster-runtime 25.66% <ø> (?)
e2e-test-runtime-go 25.95% <ø> (?)
e2e-test-runtime-node 26.95% <ø> (?)
e2e-test-runtime-python 26.95% <ø> (?)
e2e-test-runtime-quarkus 27.06% <ø> (?)
e2e-test-runtime-rust 25.95% <ø> (?)
e2e-test-runtime-springboot 26.09% <ø> (?)
e2e-test-runtime-typescript 27.06% <ø> (?)
integration-tests 51.47% <ø> (+2.11%) ⬆️
unit-tests-macos-latest 48.27% <ø> (?)
unit-tests-ubuntu-latest 49.04% <ø> (?)
unit-tests-windows-latest 48.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @lkingland

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @lkingland @gauron99

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d0fe80c into knative:main Aug 22, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants