Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving func environment command #1935

Merged

Conversation

nitishchauhan0022
Copy link
Contributor

Fixes #1870

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2023

Hi @nitishchauhan0022. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.80% ⚠️

Comparison is base (1163a5e) 60.69% compared to head (b614c96) 59.89%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   60.69%   59.89%   -0.80%     
==========================================
  Files         107      106       -1     
  Lines       13819    13678     -141     
==========================================
- Hits         8387     8192     -195     
- Misses       4603     4640      +37     
- Partials      829      846      +17     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.45% <12.50%> (?)
e2e-test-oncluster-runtime 25.26% <12.50%> (?)
e2e-test-runtime-go 25.53% <12.50%> (?)
e2e-test-runtime-node 26.63% <12.50%> (?)
e2e-test-runtime-python 26.63% <12.50%> (?)
e2e-test-runtime-quarkus 26.74% <12.50%> (?)
e2e-test-runtime-rust 25.62% <12.50%> (?)
e2e-test-runtime-springboot 25.76% <12.50%> (?)
e2e-test-runtime-typescript 26.74% <12.50%> (?)
integration-tests 51.43% <12.50%> (+2.13%) ⬆️
unit-tests-macos-latest 48.17% <12.50%> (-0.10%) ⬇️
unit-tests-ubuntu-latest 48.94% <12.50%> (-0.12%) ⬇️
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/environment.go 17.36% <12.50%> (-2.16%) ⬇️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested review from lkingland and removed request for vyasgun August 15, 2023 21:41
Signed-off-by: ntishchauhan0022 <[email protected]>
@matejvasek
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2023
@matejvasek
Copy link
Contributor

matejvasek commented Aug 17, 2023

@nitishchauhan0022 this is not working well for Function that has not been deployed yet.
If Function has not been deployed we still should display Function field (but not Instance field).

@nitishchauhan0022
Copy link
Contributor Author

@matejvasek I have updated it. Please take a look.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, nitishchauhan0022

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@matejvasek
Copy link
Contributor

/retest

@matejvasek matejvasek changed the title improvising func environment command Improving func environment command Aug 18, 2023
@knative-prow knative-prow bot merged commit e04c139 into knative:main Aug 18, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: improved func environment command to also show local function information
2 participants