-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving func environment command #1935
Improving func environment command #1935
Conversation
Signed-off-by: ntishchauhan0022 <[email protected]>
Hi @nitishchauhan0022. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
- Coverage 60.69% 59.89% -0.80%
==========================================
Files 107 106 -1
Lines 13819 13678 -141
==========================================
- Hits 8387 8192 -195
- Misses 4603 4640 +37
- Partials 829 846 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: ntishchauhan0022 <[email protected]>
/ok-to-test |
@nitishchauhan0022 this is not working well for Function that has not been deployed yet. |
Signed-off-by: ntishchauhan0022 <[email protected]>
@matejvasek I have updated it. Please take a look. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, nitishchauhan0022 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes #1870