Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: faster make build #1937

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Aug 17, 2023

Changes

  • 🧹 Faster make build.
  • 🐛 The zz_filesystem_generated.go file must be build after CA bundle download.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2023
@matejvasek matejvasek requested review from gauron99 and removed request for maximilien and rhuss August 17, 2023 17:20
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.93% 🎉

Comparison is base (da658c1) 61.82% compared to head (c28077a) 62.75%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   61.82%   62.75%   +0.93%     
==========================================
  Files         106      106              
  Lines       13657    13657              
==========================================
+ Hits         8443     8571     +128     
+ Misses       4369     4216     -153     
- Partials      845      870      +25     
Flag Coverage Δ
e2e-test 35.26% <ø> (ø)
e2e-test-oncluster 30.42% <ø> (+0.02%) ⬆️
e2e-test-oncluster-runtime 25.29% <ø> (?)
e2e-test-runtime-node 26.66% <ø> (?)
e2e-test-runtime-python 26.66% <ø> (?)
e2e-test-runtime-quarkus 26.78% <ø> (?)
e2e-test-runtime-rust 25.56% <ø> (?)
e2e-test-runtime-springboot 25.79% <ø> (?)
e2e-test-runtime-typescript 26.78% <ø> (?)
integration-tests 51.49% <ø> (+2.15%) ⬆️
unit-tests-macos-latest 48.24% <ø> (ø)
unit-tests-ubuntu-latest 49.03% <ø> (+0.02%) ⬆️
unit-tests-windows-latest 48.26% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @lkingland @gauron99

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9224134 into knative:main Aug 22, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants