Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align dependencies with Knative #1942

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2023
@matejvasek matejvasek requested review from lkingland, gauron99 and dsimansk and removed request for gauron99 and vyasgun August 24, 2023 13:33
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 80.95% and project coverage change: -15.97% ⚠️

Comparison is base (9224134) 56.57% compared to head (b6c32cd) 40.61%.

❗ Current head b6c32cd differs from pull request most recent head b7e62d2. Consider uploading reports for the commit b7e62d2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1942       +/-   ##
===========================================
- Coverage   56.57%   40.61%   -15.97%     
===========================================
  Files         106      105        -1     
  Lines       13678    13676        -2     
===========================================
- Hits         7739     5554     -2185     
- Misses       5161     7388     +2227     
+ Partials      778      734       -44     
Flag Coverage Δ
e2e-test 35.22% <66.66%> (ø)
e2e-test-oncluster 30.38% <57.14%> (?)
e2e-test-oncluster-runtime 25.26% <0.00%> (?)
e2e-test-runtime-go 25.59% <42.85%> (?)
e2e-test-runtime-node 26.63% <42.85%> (?)
e2e-test-runtime-python 26.63% <42.85%> (?)
e2e-test-runtime-quarkus 26.74% <42.85%> (?)
e2e-test-runtime-rust 25.62% <42.85%> (?)
e2e-test-runtime-springboot 25.76% <42.85%> (?)
e2e-test-runtime-typescript 26.74% <42.85%> (?)
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/k8s/dialer.go 18.89% <33.33%> (+17.15%) ⬆️
pkg/k8s/persistent_volumes.go 61.02% <100.00%> (+54.35%) ⬆️
pkg/knative/deployer.go 60.37% <100.00%> (-1.76%) ⬇️

... and 70 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2023
@matejvasek matejvasek changed the title chore: clean up go.mod file chore: align dependencies with Knative Aug 25, 2023
@matejvasek
Copy link
Contributor Author

PTAL @dsimansk

go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@matejvasek
Copy link
Contributor Author

/retest

@matejvasek
Copy link
Contributor Author

@matejvasek matejvasek requested a review from aslom August 28, 2023 18:20
@matejvasek
Copy link
Contributor Author

plz lgtm @dsimansk

@jrangelramos
Copy link
Contributor

/lgtm
/hold for @dsimansk

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@matejvasek
Copy link
Contributor Author

/unhold

@matejvasek matejvasek removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@knative-prow knative-prow bot merged commit 60e0c71 into knative:main Aug 29, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants