Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better JSON Schema #1968

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@matejvasek matejvasek requested review from jrangelramos and removed request for maximilien and rhuss September 12, 2023 17:09
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.00% 🎉

Comparison is base (a4e4885) 61.68% compared to head (fd439c7) 62.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   61.68%   62.68%   +1.00%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8446     8584     +138     
+ Misses       4400     4238     -162     
- Partials      847      871      +24     
Flag Coverage Δ
e2e-test 35.18% <ø> (ø)
e2e-test-oncluster 30.42% <ø> (-0.03%) ⬇️
e2e-test-oncluster-runtime 25.23% <ø> (?)
e2e-test-runtime-go 25.56% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.43% <ø> (+2.11%) ⬆️
unit-tests-macos-latest 48.21% <ø> (?)
unit-tests-ubuntu-latest 49.00% <ø> (?)
unit-tests-windows-latest 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/functions/function.go 85.85% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @gauron99

@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@knative-prow knative-prow bot merged commit 4cbba4a into knative:main Sep 13, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants