fix: use overlay storage for s2i

[matejvasek]

Changes

• 🎁 Use overlay storage for buildah instead of vfs in s2i on cluster build. It is much more efficient where vfs takes 5.5G overlay takes just 1.2G.

Use overlay storage driver instead of vfs driver in s2i tekton task.

[knative-prow]

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.71%. Comparing base (a4e4885) to head (4976df0).
Report is 157 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1969      +/-   ##
==========================================
+ Coverage   61.68%   62.71%   +1.02%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8446     8587     +141     
+ Misses       4400     4236     -164     
- Partials      847      870      +23     

Flag	Coverage Δ
e2e-test	35.21% <ø> (+0.02%)	⬆️
e2e-test-oncluster	30.53% <ø> (+0.08%)	⬆️
e2e-test-oncluster-runtime	25.23% <ø> (?)
e2e-test-runtime-go	25.59% <ø> (?)
e2e-test-runtime-node	26.60% <ø> (?)
e2e-test-runtime-python	26.60% <ø> (?)
e2e-test-runtime-quarkus	26.71% <ø> (?)
e2e-test-runtime-rust	25.50% <ø> (?)
e2e-test-runtime-springboot	25.73% <ø> (?)
e2e-test-runtime-typescript	26.71% <ø> (?)
integration-tests	51.40% <ø> (+2.07%)	⬆️
unit-tests-macos-latest	48.21% <ø> (?)
unit-tests-ubuntu-latest	49.00% <ø> (?)
unit-tests-windows-latest	48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matejvasek]

/hold
we must make sure this works on variety of clusters.

[matejvasek]

@grafvonb Hi, if you had some spare time would you please verify this works on EKS?

[matejvasek]

@trisberg Hi, if you had some spare time would you please verify this works on GKE?

[matejvasek]

Note: when testing this locally you need to set

	FuncRepoRef       = "matejvasek/faas"
	FuncRepoBranchRef = "try-overlay"

in

func/pkg/pipelines/tekton/templates.go

Lines 91 to 92 in 67517b7

	FuncRepoRef = "knative/func"
	FuncRepoBranchRef = "main"

[matejvasek]

The thing is: overlays storage may not work on some cluster.

[jrangelramos]

Hi @matejvasek it works on OCP.

[matejvasek]

@jrangelramos While testing did you update FuncRepoRef and FuncRepoBranchRef?

[jrangelramos]

@jrangelramos While testing did you update FuncRepoRef and FuncRepoBranchRef?

Yes! I did

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[jrangelramos]

/remove-lifecycle stale

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.