Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #2518

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[main] Upgrade to latest dependencies #2518

merged 1 commit into from
Sep 25, 2024

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-automation
upgrade to latest dependencies
906ce9e 
bumping knative.dev/pkg aabe552...28b58b8:
  > 28b58b8 Use istio.sidecar.inject label instead of annotation (# 3096)
bumping knative.dev/serving 59d17f1...ca64728:
  > ca64728 Update net-contour nightly (# 15526)
  > e896849 Update net-kourier nightly (# 15525)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 25, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/func-approvers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.92%. Comparing base (783d04d) to head (906ce9e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   61.43%   66.92%   +5.48%     
==========================================
  Files         130      130              
  Lines       15479    12048    -3431     
==========================================
- Hits         9510     8063    -1447     
+ Misses       5028     3009    -2019     
- Partials      941      976      +35
Flag Coverage Δ
e2e-test 36.59% <ø> (+0.04%) ⬆️
e2e-test-oncluster 33.36% <ø> (-0.02%) ⬇️
e2e-test-oncluster-runtime 29.70% <ø> (?)
e2e-test-runtime-go 26.56% <ø> (?)
e2e-test-runtime-node 25.95% <ø> (?)
e2e-test-runtime-python 25.95% <ø> (?)
e2e-test-runtime-quarkus 26.05% <ø> (?)
e2e-test-runtime-rust 25.07% <ø> (?)
e2e-test-runtime-springboot 25.13% <ø> (?)
e2e-test-runtime-typescript 26.04% <ø> (?)
integration-tests 53.06% <ø> (+2.38%) ⬆️
unit-tests 51.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@knative-prow knative-prow bot merged commit ba3bd79 into knative:main Sep 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-automation @matzew