-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Python Middleware v2 Scaffolding #2685
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fmt.Printf("cd %v\n", job.Dir()) | ||
} | ||
|
||
// TODO: should we allow the python binary location to be specified with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was that done before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands presume the binaries are available in PATH
, and use the first match. This is common. However, a nice feature offered by some is to be able to override this on a case-by-case basis by setting environment variables such as MYAPP_PYTHON=/path/to/python
. We also support this in some cases, but not consistently throughout. This might be a #good-first-issue
nice for getting this started |
This is a draft of the Python v2 middleware which supports the Scaffolding system.
/kind enhancement