Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssh dockerd connectivity #520

Closed
wants to merge 3 commits into from

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Sep 10, 2021

  • 🎁 Add connectivity via SSH tunnel to remote docker daemons.
    Useful for instance when connecting to podman VM in macOS.

resolves #469

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021
@matejvasek
Copy link
Contributor Author

Just draft for now, need to decide what to do with https://github.com/matejvasek/sshdialer
Should I keep it as a library or just copy/paste code? what do you think?

Also the code from https://github.com/matejvasek/sshdialer will be used for buildpacks/pack#1259.

@matejvasek
Copy link
Contributor Author

For now this will work with:

  • pwd in ssh url e.g. ssh://user:pwd@host/path/to/podman.sock
  • keys managed by ssh-agent
  • keys with standard names in ~/.ssh/ that are not protected by passphrase

@matejvasek
Copy link
Contributor Author

@zroubalik or @lkingland if you have some spare time could you please try this out on macOS?

this allows to connect to remote docker deamons via ssh

Signed-off-by: Matej Vasek <[email protected]>
k8s.io/api v0.19.7
k8s.io/apimachinery v0.19.7
k8s.io/client-go v0.19.7
k8s.io/api v0.20.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why go mod tidy did this.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2021
@knative-prow-robot
Copy link

@matejvasek: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Matej Vasek <[email protected]>
@matejvasek matejvasek closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ssh connectivity for docker API
2 participants