Trying not to mask the error

knative · Sep 13, 2024 · d0540bf · d0540bf
1 parent 3d045ff
commit d0540bf
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/vendor/knative.dev/reconciler-test/pkg/environment/images.go b/vendor/knative.dev/reconciler-test/pkg/environment/images.go
@@ -96,10 +96,14 @@ func ProduceImages(ctx context.Context) (map[string]string, error) {
 			continue
 		}
 		image, err := ip(ctx, pack)
+		if err != nil {
+			return nil, fmt.Errorf("Error building image: %w", err)
+		}
 		if errors.Is(err, ko.ErrKoPublishFailed) {
 			logging.FromContext(ctx).Warnw("Ko publish failed, using image directly", "error", err, "image", pack)
 			image = pack
-			err = nil
+			return nil, fmt.Errorf("Error building image for %s: %w", image, err)
+			//err = nil
 		}
 		if err != nil {
 			return nil, err