Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 1534 to release 1.11 #1536

Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 17, 2023

Manual cherrypick of #1534 as automated cherrypick failed: #1535

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ef32df) 79.22% compared to head (f57448c) 79.22%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #1536   +/-   ##
=============================================
  Coverage         79.22%   79.22%           
=============================================
  Files                40       40           
  Lines              1800     1800           
=============================================
  Hits               1426     1426           
  Misses              272      272           
  Partials            102      102           
Files Changed Coverage Δ
...knativeeventing/common/replicasenvvarstransform.go 70.58% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@knative-prow knative-prow bot merged commit d1386e5 into knative:release-1.11 Aug 17, 2023
17 checks passed
@aliok aliok deleted the cherry-pick-1534-to-release-1.11 branch August 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants