Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add resources requests and limits #1571

Closed
wants to merge 1 commit into from
Closed

chore: Add resources requests and limits #1571

wants to merge 1 commit into from

Conversation

kahirokunn
Copy link
Contributor

Fixes #

Proposed Changes

  • If resources requests are left out, they will be given a lower priority when scheduled, so we have assigned them to all.

Release Note

chore: Add resources requests and limits

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2023
matzew
matzew reviewed Oct 9, 2023
View reviewed changes
config/charts/knative-operator/templates/operator.yaml
@@ -6245,5 +6245,12 @@ spec:
ports:
- name: metrics
containerPort: 9090
resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these numbers come from any verification or such?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have verified this in my environment on a metrics basis and it works well with this value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not a problem, I'll try to fix the unit test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew Your opinion.
Does it seem safe to proceed with implementation?
Thx.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@kahirokunn
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2024
@github-actions github-actions bot closed this Sep 21, 2024
@kahirokunn
Copy link
Contributor Author

/reopen

@knative-prow knative-prow bot reopened this Sep 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 21, 2024

@kahirokunn: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please ask for approval from houshengbo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 21, 2024

@kahirokunn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_operator_main a6338f6 link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2024
@houshengbo
Copy link
Contributor

@kahirokunn we ultimately added requests and limits, as in https://github.com/knative/operator/blob/main/config/manager/operator.yaml#L41

@houshengbo houshengbo closed this Oct 14, 2024
@kahirokunn
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@houshengbo houshengbo Awaiting requested review from houshengbo

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@houshengbo houshengbo

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kahirokunn @houshengbo @matzew