Improve manifest deletion error handling #1589
Conversation
It might happen that not all resources were created successfully so we should not fail finalization when resources are not found, we can just ignore not found errors. Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
bot
added
size/XS
|
/cherry-pick release-1.11 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.10 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 41 41
Lines 1845 1845
=======================================
Hits 1465 1465
Misses 277 277
Partials 103 103
☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Cherry pick done manually in #1591 |
|
/retest-required |
|
/test eventing-upgrade-tests |
|
@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It might happen that not all resources were created successfully so we should not fail finalization when resources are not found, we can just ignore not found errors.