-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disable via regex in chaosduck #2117
Allow disable via regex in chaosduck #2117
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
+ Coverage 67.39% 67.44% +0.04%
==========================================
Files 215 215
Lines 9116 9116
==========================================
+ Hits 6144 6148 +4
+ Misses 2697 2695 -2
+ Partials 275 273 -2
Continue to review full report at Codecov.
|
LGTM |
can we have |
I thought about that @dprotaso, but eventually opted for the easier solution. I'll take another look. |
0c495c9
to
ee65ce5
Compare
/retest Unrelated. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes
It's been kinda annoying trying to come up with the exact list of webhooks to ignore and this has caused intermediate flakiness. This adds the possibility to exclude components via a regex, so all webhooks can be excluded more easily and scalably.
/assign @nak3 @dprotaso