-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jaeger tracing backend support #2562
Conversation
Signed-off-by: Dirk Haubenreisser <[email protected]>
Signed-off-by: Dirk Haubenreisser <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haubenr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #2562 +/- ##
==========================================
- Coverage 81.61% 81.37% -0.24%
==========================================
Files 163 163
Lines 9715 9747 +32
==========================================
+ Hits 7929 7932 +3
- Misses 1549 1579 +30
+ Partials 237 236 -1
Continue to review full report at Codecov.
|
Signed-off-by: Dirk Haubenreisser <[email protected]>
/test unit-tests_pkg_main |
The Downstream Tekton 'tektoncd/pipeline' fails due to an unrelated issue with the knative.dev/pkg/changeset module where the interface expectation of tekton (wants to receive two return values) is not matched by the actual knative function implementation (returns one value). |
/hold - see my comment on the issue |
Alright, moving from OpenCensus to OpenTelemetry sound reasonable. I'll close this PR. |
Changes
This PR adds Jaeger tracing backend support to the tracing package (in addition to the already existing Zipkin support).
Parts of the code in this PR were taken from an earlier (and seemingly abandoned code change proposed here: #1079
/kind enhancement
Fixes #2561