fix http debugging

knative · Jan 15, 2025 · 6cbf1a7 · 6cbf1a7
1 parent 12f0b78
commit 6cbf1a7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/config/core/deployments/activator.yaml b/config/core/deployments/activator.yaml
@@ -87,7 +87,7 @@ spec:
         - name: METRICS_DOMAIN
           value: knative.dev/internal/serving
         - name: GODEBUG
-          value: "http1debug=2"
+          value: "http2debug=2"
 
         securityContext:
           allowPrivilegeEscalation: false

diff --git a/pkg/reconciler/revision/resources/queue.go b/pkg/reconciler/revision/resources/queue.go
@@ -462,7 +462,7 @@ func makeQueueContainer(rev *v1.Revision, cfg *config.Config) (*corev1.Container
 			Value: cfg.Deployment.QueueSidecarRootCA,
 		}, {
 			Name:  "GODEBUG",
-			Value: "http1debug=2", // Enable HTTP/1.1 debugging
+			Value: "http2debug=2", // Enable HTTP2 debugging
 		},
 			{
 				Name:  "ENABLE_MULTI_CONTAINER_PROBES",

diff --git a/test/conformance/runtime/readiness_probe_test.go b/test/conformance/runtime/readiness_probe_test.go
@@ -127,7 +127,7 @@ func TestProbeRuntime(t *testing.T) {
 
 				t.Log("Creating a new Service")
 				envs := tc.env
-				envs = append(tc.env, corev1.EnvVar{Name: "GODEBUG", Value: "http1debug=2"})
+				envs = append(tc.env, corev1.EnvVar{Name: "GODEBUG", Value: "http2debug=2"})
 				resources, err := v1test.CreateServiceReady(t, clients, &names,
 					v1opts.WithEnv(envs...),
 					v1opts.WithReadinessProbe(

diff --git a/vendor/knative.dev/pkg/network/transports.go b/vendor/knative.dev/pkg/network/transports.go
@@ -152,7 +152,8 @@ func NewProberTransport() http.RoundTripper {
 // NewProxyAutoTLSTransport is same with NewProxyAutoTransport but it has DialTLSContextFunc to create HTTPS request.
 func NewProxyAutoTLSTransport(maxIdle, maxIdlePerHost int, tlsContext DialTLSContextFunc) http.RoundTripper {
 	return newAutoTransport(
-		newHTTPSTransport(false /*disable keep-alives*/, true /*disable auto-compression*/, maxIdle, maxIdlePerHost, tlsContext),
+		//newHTTPSTransport(false /*disable keep-alives*/, true /*disable auto-compression*/, maxIdle, maxIdlePerHost, tlsContext),
+		newH2Transport(true /*disable auto-compression*/, tlsContext),
 		newH2Transport(true /*disable auto-compression*/, tlsContext))
 }