-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighter Acceptance Criteria in TestCustomResources #6006
Comments
/assign @coryrc |
Also move to e2e to address this comment: #6014 (comment) |
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Include changes from knative#6006 work
Issues go stale after 90 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /lifecycle stale |
Fixes knative#6006 by making TestCustomResourceLimits to be a conformance test and moving e2e parts out. For knative#6226 fixes it for TestContainerErrorMsg and TestContainerExitingMsg, though could be other tests checking errors incorrectly. Addresses knative#6264 though continuing work is needed. Don't mix E2E and conformance: Strip E2E portions of conformance out into tests in the test/e2e directory. Commonality goes into test/scenarios or test/v1 depending on specificity of the common functionality. Rename to more align with runtime test naming (Must/Should).
Fixes knative#6006 by making TestCustomResourceLimits to be a conformance test and moving e2e parts out. For knative#6226 fixes it for TestContainerErrorMsg and TestContainerExitingMsg, though could be other tests checking errors incorrectly. Addresses knative#6264 though continuing work is needed. Don't mix E2E and conformance: Strip E2E portions of conformance out into tests in the test/e2e directory. Commonality goes into test/scenarios or test/v1 depending on specificity of the common functionality. Rename to more align with runtime test naming (Must/Should).
Stale issues rot after 30 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /lifecycle rotten |
Rotten issues close after 30 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /close |
@knative-housekeeping-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@dprotaso: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There's a fix in #6978 for anyone who wants to break it out. |
/assign |
This issue is stale because it has been open for 90 days with no |
/lifecycle frozen |
/triage accepted Should this move to https://github.com/knative/specs ? |
/area test-and-release
serving/test/conformance/api/v1/resources_test.go
Line 114 in aba4def
this accepts any indication other than StatusOK, like BadRequest, rather than just not getting a response/closed socket. Should be more precise in acceptance.
/assign
The text was updated successfully, but these errors were encountered: