Restructure Conformance API tests to match Spec #6978
Conversation
knative-prow-robot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coryrc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@coryrc: 7 warnings.
In response to this:
Fixes #6006 by making TestCustomResourceLimits to be a conformance
test and moving e2e parts out.For #6226 fixes it for TestContainerErrorMsg and
TestContainerExitingMsg, though could be other tests checking errors
incorrectly.Addresses #6264 though continuing work is needed.
Don't mix E2E and conformance:
Strip E2E portions of conformance out into tests in the test/e2e
directory. Commonality goes into test/scenarios or test/v1 depending
on specificity of the common functionality.Rename to more align with runtime test naming (Must/Should).
NONE/cc @dgerd
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
|
/retest |
knative-prow-robot
added
the
needs-rebase
Fixes knative#6006 by making TestCustomResourceLimits to be a conformance test and moving e2e parts out. For knative#6226 fixes it for TestContainerErrorMsg and TestContainerExitingMsg, though could be other tests checking errors incorrectly. Addresses knative#6264 though continuing work is needed. Don't mix E2E and conformance: Strip E2E portions of conformance out into tests in the test/e2e directory. Commonality goes into test/scenarios or test/v1 depending on specificity of the common functionality. Rename to more align with runtime test naming (Must/Should).
coryrc
force-pushed
the
restructure-conformance
branch
from
0f2c03c
to
edc03a8
Compare
knative-prow-robot
removed
the
needs-rebase
knative-prow-robot
added
the
needs-rebase
|
@coryrc: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@coryrc any news on this one? |
|
@markusthoemmes If someone who can approve cares, I'm willing to put in the work to get this in. |
|
/assign @dprotaso I guess it's up for the API WG to decide what to do with this. |
I think there's value in this work. If you need timely approval feel free to ping me on slack. At minimum if you're timed constrained on working on these changes do you at least mind re-opening and the relevant issues you care about? |
|
Comments in #6264 |
Fixes #6006 by making TestCustomResourceLimits to be a conformance
test and moving e2e parts out.
For #6226 fixes it for TestContainerErrorMsg and
TestContainerExitingMsg, though could be other tests checking errors
incorrectly.
Addresses #6264 though continuing work is needed.
Don't mix E2E and conformance:
Strip E2E portions of conformance out into tests in the test/e2e
directory. Commonality goes into test/scenarios or test/v1 depending
on specificity of the common functionality.
Rename to more align with runtime test naming (Must/Should).
/cc @dgerd