Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kourier tls runtime tests #15732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 27, 2025

Fixes #15697

Proposed Changes

  • See comment here for why this fix is needed.
  • Brings back the disabled tests
  • Makes activator handler aware of whether we are hitting a cluster IP or a Pod IP.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
Copy link

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and psschwei January 27, 2025 17:42
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@skonto skonto requested review from dprotaso and removed request for dsimansk and psschwei January 27, 2025 17:42
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (da5e7fd) to head (8b9aab9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/activator/handler/handler.go 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15732      +/-   ##
==========================================
- Coverage   80.88%   80.81%   -0.07%     
==========================================
  Files         222      222              
  Lines       18063    18075      +12     
==========================================
- Hits        14610    14608       -2     
- Misses       3083     3096      +13     
- Partials      370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jan 28, 2025

@dprotaso gentle ping

1 similar comment
@skonto
Copy link
Contributor Author

skonto commented Jan 30, 2025

@dprotaso gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kourier TLS runtime suite fails sporadically
2 participants