Add distinct logging for timeout types #16109
Conversation
|
Welcome @thiagomedina! It looks like this is your first PR to knative/serving 🎉 |
knative-prow
bot
added
needs-ok-to-test
|
Hi @thiagomedina. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thiagomedina The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16109 +/- ##
==========================================
- Coverage 80.07% 80.06% -0.01%
==========================================
Files 214 214
Lines 16907 16911 +4
==========================================
+ Hits 13538 13540 +2
- Misses 3013 3015 +2
Partials 356 356 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@thiagomedina: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| func ErrorHandler(logger *zap.SugaredLogger) func(http.ResponseWriter, *http.Request, error) { | ||
| return func(w http.ResponseWriter, req *http.Request, err error) { | ||
| if errors.Is(err, context.Canceled) { |
There was a problem hiding this comment.
This change would be done: https://github.com/knative/pkg
| body: scenario.timeoutMessage, | ||
| timeoutFunc: StaticTimeoutFunc(scenario.timeout, scenario.responseStartTimeout, scenario.idleTimeout), | ||
| clock: fakeClock, | ||
| logger: zap.NewNop().Sugar(), |
There was a problem hiding this comment.
Can we use a zap test logger? https://pkg.go.dev/go.uber.org/zap/zaptest#NewLogger
Fixes #15752
Fixes #13746
Proposed Changes
Release Note