Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

[WIP] Initial setup for running the website in Docker #286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mpetason
Copy link
Contributor

@mpetason mpetason commented Apr 7, 2021

Changes

  • Adds documentation on how to run in Docker

/kind documentation

Fixes #

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abrennan89 after the PR has been reviewed.
You can assign the PR to them by writing /assign @abrennan89 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2021
@mpetason
Copy link
Contributor Author

mpetason commented Apr 7, 2021

Looking on feedback:

  • Where should this live, is this the right directory or should we put this in Docs
  • I'm editing scripts used to build the site and am including them with the docker build option - should we build an image and host it in dockerhub - do we have a knative dockerhub user?
  • Interested in any feedback on building the image - I'm using a larger base and am installing the Hugo version we use to make sure that we have extended. The image is around 695MB right now.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 7, 2021
@mpetason mpetason changed the title Initial setup for running the website in Docker [WIP] Initial setup for running the website in Docker Apr 7, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we have an official place for these sorts of Docker images; most of our images are built during our release process by Prow; I'm not sure what the best option is here.

I would suggest mentioning your current Docker images on DockerHub (assuming that they're public) as an easier way than needing to do your own local docker build.

docker/README.md Outdated
This will run the service on port 9001, but you can pick any port you want. The container is listening on 1313.


Diffs on script files (edited so that mounted volumes aren't deleted or copied over)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Rather than putting the script here, why not have a .patch file created by something like:

diff -u ../website/scripts/localbuild.sh localbuild.sh >> diff.patch
diff -u ../website/scripts/processresourcefiles.sh processresourcefiles.sh >> diff.patch

This would allow you to use the patch command to apply the patch to the original files in the Docker build, and avoid needing to keep an extra copy of the scripts here with only a few lines changed.

@mpetason
Copy link
Contributor Author

Addressed the review requests. Looking for more feedback on where this should live, right now it's website/docker. I don't know if that will cause any issues. It looks like the tests are failing right now due to another issue related to an addition recently.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2021
@knative-prow-robot
Copy link
Contributor

@mpetason: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants