Update error messages

kngys · Nov 7, 2024 · d02bc70 · d02bc70
1 parent 967f524
commit d02bc70
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/main/java/seedu/address/logic/Messages.java b/src/main/java/seedu/address/logic/Messages.java
@@ -26,8 +26,10 @@ public class Messages {
     public static final String MESSAGE_DUPLICATE_FIELDS =
                 "Multiple values specified for the following single-valued field(s): ";
     public static final String MESSAGE_INVALID_AMOUNT = "Incorrect amount format or invalid amount!\n"
-            + "Amount should be a number of up to 2 decimal places containing only digits (0-9) and 1 decimal point. "
-            + "There should be at least 1 digit before the decimal point.";
+            + "Amount should be a number of up to 2 decimal places.\n"
+            + "Amount should contain only digits (0-9), at most 1 decimal point (.), and at most 1 minus sign (-).\n"
+            + "If decimal point is used, there should be at least 1 digit before the decimal point.\n"
+            + "If the minus sign is used, it should be the first character.";
     public static final String MESSAGE_INVALID_DATE_FORMAT = "Incorrect date format or invalid date!\n"
             + "Date format: YYYY-MM-DD";
     public static final String MESSAGE_INVALID_MONTH_FORMAT = "Incorrect month format or invalid month!\n"
@@ -45,6 +47,9 @@ public class Messages {
     public static final String MESSAGE_EMPTY_OTHER_PARTY = "Other party should not be blank!";
     public static final String MESSAGE_EMPTY_DATE = "Date should not be blank!";
 
+    public static final String MESSAGE_EMPTY_PERSON_LIST =
+            "Current person list is empty!\n" + "%1$s command must only be used on non-empty person list.";
+
     public static final String MESSAGE_EMPTY_TRANSACTION_LIST =
             "Invalid command: The current transaction list is empty.";
     /**

diff --git a/src/main/java/seedu/address/logic/commands/AddTransactionCommand.java b/src/main/java/seedu/address/logic/commands/AddTransactionCommand.java
@@ -67,6 +67,10 @@ public CommandResult execute(Model model) throws CommandException {
         }
 
         List<Person> lastShownList = model.getFilteredPersonList();
+        if (lastShownList.isEmpty()) {
+            throw new CommandException(String.format(Messages.MESSAGE_EMPTY_PERSON_LIST, COMMAND_WORD));
+        }
+
         if (index.getZeroBased() >= lastShownList.size()) {
             logger.fine("CommandException caused by invalid index.");
             throw new CommandException(Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX);