Fix type compatibility where casting is needed #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsterkrampe
added
bug
monsterkrampe
force-pushed
the
bugfix/394-attempt-to-upgrade-values-to-any-leads-to-unreachable-code-being-executed
branch
from
69b253d to
1ea2809
Compare
monsterkrampe
commented
Nov 1, 2023
| @@ -133,14 +133,6 @@ impl Deref for TupleConstraint { | |||
| } | |||
| } | |||
|
|
|||
| impl FromIterator<PrimitiveType> for TupleConstraint { | |||
There was a problem hiding this comment.
I removed this since I found it confusing. I was actually expecting that this would always be turned into AtLeast constraints instead of Exact constraints, e.g. when using this on Data Sources.
I think one should rather make this explicit and use the FromIterator implementation below.
monsterkrampe
commented
Nov 1, 2023
| @@ -690,6 +690,7 @@ impl<'a> RuleParser<'a> { | |||
| /// predicate name together with its arity. | |||
| fn parse_qualified_predicate_name( | |||
| &'a self, | |||
| constraint_is_lower_bound: bool, | |||
There was a problem hiding this comment.
When parsing source declarations, the type annotations are always lower bounds. In other cases like outputs, these requirements might be stricter. (Since import / export directives are WIP, I would not polish this right now as I expect things to change in the parser anyway.)
mmarx
approved these changes
Nov 1, 2023
monsterkrampe
deleted the
bugfix/394-attempt-to-upgrade-values-to-any-leads-to-unreachable-code-being-executed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394