Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Permutation using slices #554

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Implement Permutation using slices #554

merged 4 commits into from
Dec 9, 2024

Conversation

matzemathics
Copy link
Collaborator

This is a re-implementation of Permutation getting rid of the inner HashMap, the main benefit being that Permutation can now derive(Ord). This is useful, because it is used as a key in the ColumnOrderMap. Also it is probably more memory efficient.

@matzemathics matzemathics requested a review from aannleax December 4, 2024 10:47
aannleax
aannleax approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@aannleax aannleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aannleax aannleax merged commit 25e6137 into main Dec 9, 2024
8 checks passed
@aannleax aannleax deleted the orderable_permutation branch December 9, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aannleax aannleax aannleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
nemo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzemathics @aannleax