Introduce feature to disable blocking mode #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrssv
force-pushed
the
force-non-blocking
branch
from
593ec6a to
bb1b1ce
Compare
Urhengulas
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Looks generally good to me. But I want @jonathanpallant to have a look before merging to ensure it does not interfere with defmt 1.0.
Co-authored-by: Johann Hemmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the feature
disable-blocking-modewhich prevents the host from putting rtt into blocking mode, by which I've got bitten a couple of times because I tend to just unplug my devices. However with blocking mode they will just hang once the buffer is full. Since I do not log too much blocking is not of great benefit to me whereas not having the mcu hang is.