Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve histogram consistency #161

Merged
merged 1 commit into from
Aug 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions prometheus.lua
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,9 @@ local function observe(self, value, label_values)
-- _sum metric.
c:incr(keys[2], value)

-- the last bucket (le="Inf").
c:incr(keys[self.bucket_count+3], 1)

local seen = false
-- check in reverse order, otherwise we will always
-- need to traverse the whole table.
Expand All @@ -618,8 +621,6 @@ local function observe(self, value, label_values)
break
end
end
-- the last bucket (le="Inf").
c:incr(keys[self.bucket_count+3], 1)
end

-- Delete all metrics for a given gauge, counter or a histogram.
Expand Down
Loading