allow 0 value as a valid value for set() and observe() #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymartin-ovh
force-pushed
the
dev/yannick.martin/allow-zero-value
branch
2 times, most recently
from
31acb01
to
e42148f
Compare
ymartin-ovh
force-pushed
the
dev/yannick.martin/allow-zero-value
branch
from
e42148f
to
cb67f4c
Compare
knyar
added a commit
that referenced
this pull request
Aug 27, 2024
|
Hey, thank you for submitting a PR. I believe current code handles zero values correctly, I've just added a couple of tests explicitly testing that: 313303f Note that you are expected to pass a number to |
|
Thanks for feedback. I miss that "not 0" in lua returns false. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address usage of observe() and set() with a 0 value.
In my case, I get 0 with No value passed for nginx_upstream_http_connect_duration_seconds while observing tonumber(ngx.var.upstream_connect_time)