Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11 Eslant Exit portal Event fix #13

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#11 Eslant Exit portal Event fix #13

wants to merge 1 commit into from

Conversation

UTengine
Copy link
Contributor

Is this format okay?

@stevewgr stevewgr marked this pull request as ready for review July 31, 2023 01:35
stevewgr
stevewgr reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@stevewgr stevewgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here:

  1. Please provide steps to reproduce?
  2. Why we add these when ZONE_INFO table doesn't even have records for eslant? It is a bit weird introducing changes for things that still don't exists in the main repository.

Could you explain?

@stevewgr stevewgr marked this pull request as draft April 30, 2024 07:16
@stevewgr stevewgr force-pushed the master branch 3 times, most recently from 2a39066 to 1ad79c1 Compare May 22, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevewgr stevewgr stevewgr left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UTengine @stevewgr