Add `offset` option to `getLocaleFromUrl` #3

ricardogama · 2016-05-17T14:44:16Z

This PR adds the offset option to getLocaleFromUrl, which makes:

ctx.getLocaleFromUrl({ offset: 1 });

Match en for paths like /foo/en/bar.

ricardogama · 2016-05-17T14:45:02Z

fundon · 2016-05-18T08:33:39Z

Could you make the green for the status of travis ci?

ricardogama · 2016-05-18T08:48:54Z

@fundon Done. Added bluebird as dev dependency for the 0.11 build to pass.

fundon · 2016-05-19T16:03:08Z

ricardogama · 2016-05-19T16:26:09Z

@fundon Thanks! When can a release be expected? Also, check out #2 regarding the npm version of this package.

fundon · 2016-05-20T04:03:58Z

ricardogama force-pushed the feature/get-locale-from-url-offset branch from 0e8dea3 to 733ed43 Compare May 17, 2016 19:33

Add offset option to getLocaleFromUrl

773f0c2

ricardogama force-pushed the feature/get-locale-from-url-offset branch from 733ed43 to 773f0c2 Compare May 18, 2016 08:46

fundon merged commit 552c850 into koa-modules:master May 19, 2016

ricardogama deleted the feature/get-locale-from-url-offset branch May 19, 2016 16:24

Provide feedback